Skip to content

Commit

Permalink
Support par with side effects (#969)
Browse files Browse the repository at this point in the history
  • Loading branch information
@EagleoutIce
EagleoutIce authored Sep 12, 2024
2 parents 61b913a + 7731bd7 commit efdcc1c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/dataflow/environments/built-in.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ registerBuiltInFunctions(true, ['for'],
registerBuiltInFunctions(true, ['repeat'], processRepeatLoop, {} )
registerBuiltInFunctions(true, ['while'], processWhileLoop, {} )
registerBuiltInFunctions(false, ['options'], defaultBuiltInProcessor, { hasUnknownSideEffects: true, forceArgs: 'all' as const } )
registerBuiltInFunctions(false, ['on.exit', 'sys.on.exit'], defaultBuiltInProcessor, { hasUnknownSideEffects: true } )
registerBuiltInFunctions(false, ['on.exit', 'sys.on.exit', 'par'], defaultBuiltInProcessor, { hasUnknownSideEffects: true } )
/* library and require is handled above */
registerBuiltInFunctions(false, ['requireNamespace', 'loadNamespace', 'attachNamespace', 'asNamespace'], defaultBuiltInProcessor, { hasUnknownSideEffects: true } )
/* downloader and installer functions (R, devtools, BiocManager) */
Expand Down

2 comments on commit efdcc1c

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"artificial" Benchmark Suite

Benchmark suite Current: efdcc1c Previous: 5ec5755 Ratio
Retrieve AST from R code 244.3292557727273 ms (105.06523342070575) 233.2907186818182 ms (97.45110804111708) 1.05
Normalize R AST 20.732574136363638 ms (36.130850714771725) 19.917075136363636 ms (34.5158156737535) 1.04
Produce dataflow information 38.736689636363636 ms (81.7967022518867) 37.43015868181818 ms (79.35445410536298) 1.03
Total per-file 820.7649801818181 ms (1447.6873319000863) 799.1242539545455 ms (1405.241136246055) 1.03
Static slicing 2.270027323358154 ms (1.219147605623524) 2.2835471638828966 ms (1.2756604468344452) 0.99
Reconstruct code 0.23494648743631283 ms (0.191290338672367) 0.22306814497873728 ms (0.17216824146737347) 1.05
Total per-slice 2.5219821771767497 ms (1.2797649136397435) 2.5225635539266658 ms (1.328507146779839) 1.00
failed to reconstruct/re-parse 0 # 0 # 1
times hit threshold 0 # 0 # 1
reduction (characters) 0.7869360165281424 # 0.7869360165281424 # 1
reduction (normalized tokens) 0.7639690077689504 # 0.7639690077689504 # 1
memory (df-graph) 147.42458274147728 KiB (358.6827375397903) 147.42458274147728 KiB (358.6827375397903) 1

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"social-science" Benchmark Suite

Benchmark suite Current: efdcc1c Previous: 5ec5755 Ratio
Retrieve AST from R code 244.24328476 ms (46.03904617588049) 237.69329584 ms (43.84340925172529) 1.03
Normalize R AST 22.44657388 ms (16.534332491424074) 21.9065619 ms (16.225847445998614) 1.02
Produce dataflow information 75.87737295999999 ms (89.19019778927287) 74.67179426 ms (88.28330200016099) 1.02
Total per-file 11034.43747302 ms (52591.38007071751) 10810.819275639999 ms (51897.778865580585) 1.02
Static slicing 21.556877433476604 ms (78.8125587266002) 21.057520127739036 ms (77.76167376331098) 1.02
Reconstruct code 0.24109641058495232 ms (0.14897253525690377) 0.22169126925109592 ms (0.13858017956284233) 1.09
Total per-slice 21.806304995205082 ms (78.83521064812285) 21.28670664379957 ms (77.7851923602881) 1.02
failed to reconstruct/re-parse 0 # 0 # 1
times hit threshold 0 # 0 # 1
reduction (characters) 0.8862013459637729 # 0.8925178291385903 # 0.99
reduction (normalized tokens) 0.8339515062511054 # 0.8508531059077417 # 0.98
memory (df-graph) 145.7402734375 KiB (153.4526987962704) 145.84685546875 KiB (153.44623089940248) 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.