Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor of reconstruct.ts #484

Draft
wants to merge 111 commits into
base: main
Choose a base branch
from

Conversation

Ehcsan
Copy link
Collaborator

@Ehcsan Ehcsan commented Nov 7, 2023

Preliminary grouping of code parts via comments to get an overview of what to separate into new files

@Ehcsan Ehcsan self-assigned this Nov 7, 2023
src/reconstruct/reconstruct.ts Outdated Show resolved Hide resolved
src/reconstruct/reconstruct.ts Outdated Show resolved Hide resolved
@EagleoutIce
Copy link
Member

Please be aware of #507 which requires you to slightly adapt your current test structure, just ping me if i should do this for you.

src/reconstruct/helper.ts Show resolved Hide resolved
src/reconstruct/helper.ts Outdated Show resolved Hide resolved
src/reconstruct/helper.ts Outdated Show resolved Hide resolved
src/reconstruct/helper.ts Outdated Show resolved Hide resolved
src/reconstruct/helper.ts Outdated Show resolved Hide resolved
src/reconstruct/helper.ts Outdated Show resolved Hide resolved
src/reconstruct/helper.ts Outdated Show resolved Hide resolved
src/reconstruct/reconstruct.ts Outdated Show resolved Hide resolved
*WIP* plain and merge have been implemented, however functionality could not be tested due to single error from reconstructRawBinaryOperator returning wrong type
src/reconstruct/helper.ts Outdated Show resolved Hide resolved
src/reconstruct/helper.ts Outdated Show resolved Hide resolved
src/reconstruct/helper.ts Outdated Show resolved Hide resolved
src/reconstruct/helper.ts Outdated Show resolved Hide resolved
src/reconstruct/helper.ts Outdated Show resolved Hide resolved
src/reconstruct/helper.ts Outdated Show resolved Hide resolved
src/reconstruct/helper.ts Outdated Show resolved Hide resolved
src/reconstruct/reconstruct.ts Outdated Show resolved Hide resolved
@EagleoutIce
Copy link
Member

@EagleoutIce resolve conflicts

@@ -0,0 +1,5 @@
{
"cSpell.words": [
"unnesseccary"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Das sollte nicht gemutet werden :D

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ich wusste gar nicht das in den settings was geändert wurde 😅

@EagleoutIce
Copy link
Member

EagleoutIce commented May 11, 2024

I have started the merge in Ehcsan-484-refactor-reconstruct. However there are a few things left todo that maybe you can do @Ehcsan:

  1. location is now an array and you can use getRangeStart and getRangeEnd to access the respective components easily (instead of .start.line etc.)
  2. The tests now have labels but i did not merge the new labels with your updates jet.

@Ehcsan
Copy link
Collaborator Author

Ehcsan commented May 12, 2024

I have started the merge in Ehcsan-484-refactor-reconstruct. However there are a few things left todo that maybe you can do @Ehcsan:

  1. location is now an array and you can use getRangeStart and getRangeEnd to access the respective components easily (instead of .start.line etc.)
  2. The tests now have labels but i did not merge the new labels with your updates jet.

I can start work on those issues on monday.
Until then, are the new locations and labels already available on the fork? @EagleoutIce

@EagleoutIce
Copy link
Member

No it isn't yet in the fork but that should happen with the sync button probably shown in your fork.

@EagleoutIce EagleoutIce marked this pull request as draft July 18, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reconstruct code deals with the code reoncsutrction at the end of the static slicing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants