-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor of reconstruct.ts #484
base: main
Are you sure you want to change the base?
Conversation
…ated its import in core\steps.ts
… commit, into new file of helper.ts. seperated import of AutoSelectPredicate in input.ts.
Please be aware of #507 which requires you to slightly adapt your current test structure, just ping me if i should do this for you. |
*WIP* plain and merge have been implemented, however functionality could not be tested due to single error from reconstructRawBinaryOperator returning wrong type
@EagleoutIce resolve conflicts |
@@ -0,0 +1,5 @@ | |||
{ | |||
"cSpell.words": [ | |||
"unnesseccary" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Das sollte nicht gemutet werden :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ich wusste gar nicht das in den settings was geändert wurde 😅
I have started the merge in Ehcsan-484-refactor-reconstruct. However there are a few things left todo that maybe you can do @Ehcsan:
|
I can start work on those issues on monday. |
No it isn't yet in the fork but that should happen with the sync button probably shown in your fork. |
Preliminary grouping of code parts via comments to get an overview of what to separate into new files