Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register Mermaid Printers for All Steps #504

Merged
merged 4 commits into from
Nov 21, 2023

Conversation

EagleoutIce
Copy link
Member

@EagleoutIce EagleoutIce commented Nov 21, 2023

Additionally, this cleans up the signature of the printers by allowing to drop the promise wrapper.

@EagleoutIce EagleoutIce linked an issue Nov 21, 2023 that may be closed by this pull request
@EagleoutIce EagleoutIce changed the title Register Mermaid Printers for the Steps Register Mermaid Printers for All Steps Nov 21, 2023
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (9e11058) 70.65% compared to head (bae38be) 70.63%.

Files Patch % Lines
src/core/print/dataflow-printer.ts 71.42% 2 Missing ⚠️
src/core/print/normalize-printer.ts 71.42% 2 Missing ⚠️
src/core/steps.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #504      +/-   ##
==========================================
- Coverage   70.65%   70.63%   -0.02%     
==========================================
  Files         212      212              
  Lines        6655     6665      +10     
  Branches     1025     1025              
==========================================
+ Hits         4702     4708       +6     
- Misses       1688     1692       +4     
  Partials      265      265              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EagleoutIce EagleoutIce merged commit aefbf04 into main Nov 21, 2023
21 checks passed
@EagleoutIce EagleoutIce deleted the 440-add-mermaid-printers-to-steps branch November 21, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Mermaid Printers to steps
1 participant