Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep Delimiters in normalized AST #536

Merged

Conversation

EagleoutIce
Copy link
Member

No description provided.

@EagleoutIce EagleoutIce linked an issue Dec 1, 2023 that may be closed by this pull request
@EagleoutIce EagleoutIce marked this pull request as draft December 1, 2023 23:20
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (f9ee22b) 70.95% compared to head (0a264eb) 71.01%.

Files Patch % Lines
...4.x/ast/parser/xml/internal/functions/parameter.ts 50.00% 0 Missing and 2 partials ⚠️
...-bridge/lang-4.x/ast/parser/xml/internal/access.ts 0.00% 0 Missing and 1 partial ⚠️
...ang-4.x/ast/parser/xml/internal/control/if-then.ts 0.00% 0 Missing and 1 partial ⚠️
...ge/lang-4.x/ast/parser/xml/internal/loops/while.ts 0.00% 0 Missing and 1 partial ⚠️
...ng-4.x/ast/parser/xml/internal/operators/binary.ts 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #536      +/-   ##
==========================================
+ Coverage   70.95%   71.01%   +0.06%     
==========================================
  Files         213      213              
  Lines        6730     6749      +19     
  Branches     1042     1048       +6     
==========================================
+ Hits         4775     4793      +18     
  Misses       1682     1682              
- Partials      273      274       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EagleoutIce EagleoutIce marked this pull request as ready for review December 5, 2023 18:50
@EagleoutIce
Copy link
Member Author

EagleoutIce commented Dec 5, 2023

@Ehcsan with this, you get the delimiter tokens that i promised you :D

@EagleoutIce EagleoutIce merged commit 60b10c5 into main Dec 5, 2023
20 checks passed
@EagleoutIce EagleoutIce deleted the 532-add-braces-parenthesis-etc-to-the-additional-tokens branch December 5, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Braces, Parenthesis etc. to the additional tokens
1 participant