Add additional ":lineage" command and message #915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasPietzschmann
added
enhancement
EagleoutIce
reviewed
Aug 28, 2024
|
After the functionality and API is completed, the message should be added to the Interface wiki page |
|
If the features as they are given here suffice for your purpose we may want to unlink the issue or outsource the rest into a new one. |
EagleoutIce
requested changes
Aug 30, 2024
Co-authored-by: Florian Sihler <florian.sihler@uni-ulm.de>
No I didn't push with --no-verify
EagleoutIce
reviewed
Aug 30, 2024
EagleoutIce
approved these changes
Aug 30, 2024
Co-authored-by: Florian Sihler <florian.sihler@uni-ulm.de>
|
I'll check asap |
|
@LukasPietzschmann are you fine with the changes? |
|
Year I'm fine with that. An hour ago I also thought about writing some tests, but looks like I forgotten about it seconds later. So thanks a lot for writing them! |
|
This pull request is included in v2.0.17 (see Release v2.0.17 (Forcing Arguments, Improved Side-Effect Detection, and Lineage Command)). |
LukasPietzschmann
added a commit
that referenced
this pull request
Sep 12, 2024
* feat: first attempt at the new getLineage command * feat: walk additional edges for determining the lineage * feat: store lineage IDs in a set * feat: prevent infinite recursion when determining the lineage IDs * feat-fix: fixed lineage network request * feat-fix: get the dfg and ast from the pipeline in the correct way * doc: added lineage request doc * feat-fix: add filetoken to error messages Co-authored-by: Florian Sihler <florian.sihler@uni-ulm.de> * feat-fix: updated comment for better clarity * feat-fix: more guards, more better * feat-fix: clearer function interface * feat-fix: removed unused import No I didn't push with --no-verify * feat-fix: removed console.log Co-authored-by: Florian Sihler <florian.sihler@uni-ulm.de> * feat-fix: criteria resolve now only requires an idmap * test(lineage): basic test setup * lint-fix: handle linter issues and empty test labels * refactor(lineage): remove redundant promise * doc(lineage): refine wiki entries --------- Co-authored-by: Florian Sihler <florian.sihler@uni-ulm.de>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new command requires a criterion and will provide the object's lineage.
Imagine the following code:
and the following request:
This will result in
[<id of b>, <id of c>, <id of x>]Basically, we just walk def and read edges in the dfg and remember the nodes we visited.
Note that the PR differs a bit from what was promised in the linked issue. Upsi :)
TODOs: