feat: adds noInstall option for Yarn packager
#421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrishutchinson
changed the title
noInstall option for Yarn packager
|
hi @chrishutchinson not sure how to cover it with e2e test either. seems like |
floydspace
previously approved these changes
Jan 6, 2023
floydspace
approved these changes
Jan 6, 2023
|
@all-contributors please add @chrishutchinson for the new code, small but valuable contribution |
|
🎉 This PR is included in version 1.37.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
I've put up a pull request to add @chrishutchinson! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been trying to get
serverless-esbuildworking with my Yarn 3.x setup, and as far as I understand the package is not compatible at the moment. After doing some testing locally, and comparing this toserverless-webpack, it looks like just deactivating the install step should be enough to get it working in my context.As such, and following the implementation in
serverless-webpackhere, I have added anoInstallpackagerOptionsoption, which exits out of the install process early. This trusts I have installed the dependencies myself.I wanted to add an e2e test to cover this scenario but I couldn't quite follow the setup of
individuallyvs.completeetc. I think I actually just want a dedicated e2e suite that is a copy of minimal with Yarn as the package manager, but I'd happily take guidance on what that should look like.Thank you!