feat: use default config when config is empty #1070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MixailE
approved these changes
Nov 18, 2024
| @@ -320,23 +341,23 @@ async function getLatestConfig<C0, C1, C2, C3, C4, C5, C6, C7, C8, C9>({ | |||
| actualConfigPath = newConfigPath; | |||
| } | |||
| } catch { | |||
| if (getDefaultConfig === undefined) { | |||
| const defaultConfigString = await getDefaultConfigString(); | |||
There was a problem hiding this comment.
discussed privately that we currently don't know any radically better way to implement this logic
| // if config file is empty for some reason - try using default | ||
| if (configString.trim() === "") { | ||
| dbg(`Config at ${actualConfigPath} is empty. Using default config`); | ||
| const defaultConfigString = await getDefaultConfigString(); |
There was a problem hiding this comment.
yeah. Decided not to move this 3 lines to a separate function or something, arguably it would be less readable in this case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.