Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(workers): add io+timer drivers to tokio runtimes [fixes NET-795] #2135

Merged
merged 13 commits into from
Mar 7, 2024

Conversation

gurinderu
Copy link
Contributor

@gurinderu gurinderu commented Mar 6, 2024

Description

Fix crashing workers tokio runtime.

Related Issue(s)

[Cite any related issues or feature requests here, using GitHub issue links.]

Proposed Changes

  • Added a panic hook
  • Enabled io & timer drivers for the worker runtimes
  • Changed UnhandledPanic to Ignore for the worker runtimes
  • Subnet resolve is async now
  • increased default idle time to 180s

Checklist

  • The code follows the project's coding conventions and style guidelines.
  • All tests related to the changes have passed successfully.
  • Documentation has been updated to reflect the changes (if applicable).
  • All new and existing unit tests have passed.
  • I have self-reviewed my code and ensured its quality.
  • I have added/updated necessary comments to aid understanding.

Reviewer Checklist

  • Code has been reviewed for quality and adherence to guidelines.
  • Tests have been reviewed and are sufficient to validate the changes.
  • Documentation has been reviewed and is up to date.
  • Any questions or concerns have been addressed.

Copy link

linear bot commented Mar 6, 2024

@gurinderu gurinderu marked this pull request as ready for review March 6, 2024 12:23
@gurinderu gurinderu changed the title fix(workers): add io+timer drivers to tokio runtimes fix(workers): add io+timer drivers to tokio runtimes [fixes NET-795] Mar 6, 2024
@gurinderu gurinderu added the e2e Run e2e workflow label Mar 6, 2024
@gurinderu gurinderu requested a review from folex March 6, 2024 13:59
@folex folex added e2e Run e2e workflow and removed e2e Run e2e workflow labels Mar 6, 2024
@gurinderu gurinderu enabled auto-merge (squash) March 6, 2024 18:33
@gurinderu gurinderu merged commit fb251c9 into master Mar 7, 2024
17 checks passed
@gurinderu gurinderu deleted the feature/net-795 branch March 7, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants