Mark ftl imports side-effect free #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #55 +/- ##
==========================================
+ Coverage 86.98% 87.50% +0.51%
==========================================
Files 4 4
Lines 146 128 -18
Branches 31 27 -4
==========================================
- Hits 127 112 -15
- Misses 7 9 +2
+ Partials 12 7 -5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Demivan
force-pushed
the
ftl-side-effects
branch
from
9368828 to
555ee58
Compare
Demivan
force-pushed
the
ftl-side-effects
branch
from
8e17a6c to
7fff275
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mark ftl file imports as side-effect free. This allows to not include them if a component is not included in a bundle.
Additionally, this greatly simplifies the plugin itself.