Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

out_datadog: Document dd_hostname configuration option #1401

Merged
merged 4 commits into from
Nov 29, 2024

Conversation

jszwedko
Copy link
Contributor

@jszwedko jszwedko commented Jul 2, 2024

Added by fluent/fluent-bit#8988

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
@@ -24,7 +24,8 @@ Before you begin, you need a [Datadog account](https://app.datadoghq.com/signup)
| dd_service | _Recommended_ - The human readable name for your service generating the logs (e.g. the name of your application or database). If unset, Datadog will look for the service using [Service Remapper](https://docs.datadoghq.com/logs/log_configuration/pipelines/?tab=service#service-attribute)." | |
| dd_source | _Recommended_ - A human readable name for the underlying technology of your service (e.g. `postgres` or `nginx`). If unset, Datadog will look for the source in the [`ddsource` attribute](https://docs.datadoghq.com/logs/log_configuration/pipelines/?tab=source#source-attribute). | |
| dd_tags | _Optional_ - The [tags](https://docs.datadoghq.com/tagging/) you want to assign to your logs in Datadog. If unset, Datadog will look for the tags in the [`ddtags' attribute](https://docs.datadoghq.com/api/latest/logs/#send-logs). | |
| dd_message_key | By default, the plugin searches for the key 'log' and remap the value to the key 'message'. If the property is set, the plugin will search the property name key. | |
| dd_message_key | By default, the plugin searches for the key 'log' and remap the value to the key 'message'. If the property is set, the plugin will search the property name key. | |
| dd_hostname | The host that emitted logs should be associated with. If unset, Datadog will expect the host to be set as `host`, `hostname`, or `syslog.hostname` attributes. See Datadog Logs preprocessor documentation for up-to-date recognized attributes. | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a link we can use to link the "Datadog Logs preprocessor documentation"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 added a link in c4d9263

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you.

jszwedko and others added 2 commits July 2, 2024 16:29
Co-authored-by: Craig Norris <112565517+cnorris-cs@users.noreply.github.com>
Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
@lecaros lecaros requested a review from cnorris-cs August 22, 2024 15:15
Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Nov 21, 2024
Copy link
Contributor

@sudomateo sudomateo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this. I'm not a maintainer but I just wanted to reset the stale bot.

@jszwedko
Copy link
Contributor Author

@cnorris-cs do you think we could merge this?

@github-actions github-actions bot removed the Stale label Nov 22, 2024
@esmerel
Copy link
Contributor

esmerel commented Nov 25, 2024

@fluent/fluent-bit-maintainers - any objections?

@lecaros lecaros merged commit b5509e7 into fluent:master Nov 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants