pipelines: filters: ecs: Retrieve container ID from record field #1402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixed a typo. Signed-off-by: Ra'Jiska <dodo.lasticot@gmail.com>
4 tasks
pipeline/filters/ecs-metadata.md
Outdated
Comment on lines
155
to
156
| Attaches the cluster metadata, as well as task metadata using the already populated field `container_id` containing the | ||
| container ID to query the ECS introspection endpoint. In this configuration the tag can be set to anything. |
There was a problem hiding this comment.
Suggested change
| Attaches the cluster metadata, as well as task metadata using the already populated field `container_id` containing the | |
| container ID to query the ECS introspection endpoint. In this configuration the tag can be set to anything. | |
| Attaches the cluster metadata and task metadata using the populated `container_id` | |
| field, which includes the container ID to query the ECS introspection endpoint. In this | |
| configuration the tag can be set to anything. |
There was a problem hiding this comment.
I'm unsure what the referenced tag is in the last sentence. Can you provide some clarification?
There was a problem hiding this comment.
Thanks for your suggested changed!
As for the last sentence, I updated to hopefully make it clearer. To put simply, currently ECS metadata requires incoming log records to have a the tag set in a format <prefix><containerid>. Formatting the tag is no longer necessary when using Container_Id_Field_Name as the container ID is retrieved through a given field within the log record.
RaJiska
force-pushed
the
ecs-container-id-field-name
branch
from
9e57b13 to
5e91178
Compare
Co-authored-by: Adam Locke <adam.locke@chronosphere.io> Signed-off-by: Doriann Corlouër <RaJiska@users.noreply.github.com>
RaJiska
force-pushed
the
ecs-container-id-field-name
branch
from
5e91178 to
adfdef3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation for PR fluent/fluent-bit#9033