Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reindent configuration file example, improve readability, etc. #1441

Merged
merged 11 commits into from
Aug 22, 2024

Conversation

sh-cho
Copy link
Contributor

@sh-cho sh-cho commented Aug 21, 2024

  • Reindent fluent-bit (classic) configuration file example with 4 spaces
    • Entries under section must be indented, 4 spaces ideally (docs)
    • You don't necessarily need to make it 4 spaces (any same indent level in single section is OK -just like python), but many people copy the example code from the documentation and try to use it, so IMO it's better to make it ideal.
  • Add empty line between sections in config file
  • Add syntax highlight for yaml ( ```yml)
  • Remove 'Line separator(U+2028)' character from vivo-exporter

Signed-off-by: Seonghyeon Cho <seonghyeoncho96@gmail.com>
Signed-off-by: Seonghyeon Cho <seonghyeoncho96@gmail.com>
Signed-off-by: Seonghyeon Cho <seonghyeoncho96@gmail.com>
Signed-off-by: Seonghyeon Cho <seonghyeoncho96@gmail.com>
Signed-off-by: Seonghyeon Cho <seonghyeoncho96@gmail.com>
Signed-off-by: Seonghyeon Cho <seonghyeoncho96@gmail.com>
Signed-off-by: Seonghyeon Cho <seonghyeoncho96@gmail.com>
Signed-off-by: Seonghyeon Cho <seonghyeoncho96@gmail.com>
Signed-off-by: Seonghyeon Cho <seonghyeoncho96@gmail.com>
LSEP(U+2028)

Signed-off-by: Seonghyeon Cho <seonghyeoncho96@gmail.com>
Signed-off-by: Seonghyeon Cho <seonghyeoncho96@gmail.com>
@sh-cho sh-cho requested review from a team as code owners August 21, 2024 15:55
Copy link
Contributor

@lockewritesdocs lockewritesdocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦖 Thanks @sh-cho!

@lecaros lecaros merged commit f689765 into fluent:master Aug 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants