patch k8s-nginx-ingress parser configuration to match latest ingress-… #1988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robberlang
force-pushed
the
patch-k8s-nginx-ingress-parser-conf
branch
2 times, most recently
from
e87d5ed
to
42c840b
Compare
…nginx version -add missing user field Signed-off-by: Rob Berlang <robberlang@tutanota.com>
|
thanks |
|
@robberlang I was trying to fix the broken parser for |
|
thanks both! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the user field back to the k8s-nginx-ingress parser configuration that was removed in the latest update: #1869
It is based on the latest (v 0.30.0) k8s ingress-nginx log format, found here: /kubernetes/ingress-nginx/blob/nginx-0.30.0/docs/user-guide/nginx-configuration/log-format.md
Test: https://rubular.com/r/IhIbCAIs7ImOkc
@arjun921 I removed the
\\*strings you added in #1869. I can't see any reason for them, looks like a mistake - matching zero or more consecutive backslashes?