in_tail: Work around "undeletable file" issue on Windows #2141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows will not actually delete a file as long as there is any open handler for it. Until we close the last open handler, the file is kept alive as "pending delete". Obviously this has been breaking the log rotation mechanism for some users. Work arount that by checking the "DeletePending" flag manually in tail_fs_check(). Signed-off-by: Fujimoto Seiji <fujimoto@ceptord.net>
|
Solves #2133 |
|
thanks @fujimotos and @farcop ! |
edsiper
pushed a commit
that referenced
this pull request
May 11, 2020
Windows will not actually delete a file as long as there is any open handler for it. Until we close the last open handler, the file is kept alive as "pending delete". Obviously this has been breaking the log rotation mechanism for some users. Work arount that by checking the "DeletePending" flag manually in tail_fs_check(). Signed-off-by: Fujimoto Seiji <fujimoto@ceptord.net>
sachinmsft
reviewed
Jun 4, 2020
|
Hello, i'm with the same error when fluent-bit 2.1.2 is in different server, reading *.json files from an network share, on Windows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows will not actually delete a file as long as there is any
open handler for it. Until we close the last open handler, the
file is kept alive as "pending delete".
Obviously this has been breaking the log rotation mechanism for
some users. Work arount that by checking the "DeletePending" flag
manually in tail_fs_check().
Signed-off-by: Fujimoto Seiji fujimoto@ceptord.net