-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
out_cloudwatch_logs: handle DataAlreadyAcceptedException response #4948
Conversation
Signed-off-by: Wesley Pettit <wppttt@amazon.com>
Hitting this issue regularly on our side, and fluent-bit fails to recover after that, this fix would help us a lot |
@edsiper Can I get a approval & merge on this? |
@Jell I'd be happy to build you a custom image using the AWS for Fluent Bit build process off of our current stable version or whichever version you are currently using, if that'd help unblock you. |
Actually @Jell I already built an image with this:
This image can be pulled by an AWS account. |
tested your image @PettitWesley it did solve our issues! Would be great to get this merged asap |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This patch solved the issues we had in production.
@agup006 this is an AWS output fix that I can't merge myself since its my PR |
I approved based off the successful tests, @PettitWesley are you able to merge now? |
@agup006 Thanks!! |
Will these changes be ported to https://github.com/aws/aws-for-fluent-bit? |
@geekofalltrades Yes, once we start releasing 1.9.x series into AWS distro. We will do this soon. We do not like to consume new series immediately, so 1.9.3 will be the first 1.9 series release we uptake probably. |
Signed-off-by: Wesley Pettit wppttt@amazon.com
Enter
[N/A]
in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.