Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in_splunk: Fix handlings for content type when http2 is off #9095

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

cosmo0920
Copy link
Contributor

Don't respond twice for Content-Type is not set.
Also, Splunk's official documentation does not mention to set Content-Type: application/json or Content-Type: text/plain.
So, we need to pass-through the request which don't use Content-Type header.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
…t-Type is not set

Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
@lecaros
Copy link
Contributor

lecaros commented Jul 16, 2024

The behavior is the expected cc @edsiper
Thanks @cosmo0920!

@edsiper edsiper merged commit 12a9de5 into master Jul 16, 2024
44 checks passed
@edsiper edsiper deleted the cosmo0920-fix-handlings-for-content-type branch July 16, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants