Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: winston@3 transport #23

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lyykfi
Copy link

@lyykfi lyykfi commented Oct 7, 2021

No description provided.

@jamiees2
Copy link
Collaborator

jamiees2 commented Oct 7, 2021

This looks great :) but I'm wondering if we should try to publish this as a separate package, e.g something like @fluent-org/winston-transport.

I think it'd be nice to maintain in the same repository, but having a separate package allows us to avoid adding winston-transport as a dependency, and having it as a peerDependency isn't a great solution either IMO.

What do you think?

@lyykfi
Copy link
Author

lyykfi commented Oct 7, 2021

I totally agree and that is fair point. :-)

How could we do that? Are you going to create another repo?

@jamiees2
Copy link
Collaborator

jamiees2 commented Oct 7, 2021

I think it'd be nice to maintain them alongside each other since the projects are still very closely related, but I'm not sure, I'll look into some approaches other projects take :)

@brunobastosg
Copy link

Any news on this? Will it be published as a separate package?

For now I'll be copying @lyykfi 's code to my project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants