Fix failure on IPv6 single stack cluster #1548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When FLUENT_FILTER_KUBERNETES_URL is not set, KUBERNETES_SERVICE_HOST and KUBERNETES_SERVICE_PORT are used as a fallback. When applying such a fallback, it will fail on only IPv6 is available. It causes the following error: /usr/local/lib/ruby/3.2.0/uri/rfc3986_parser.rb:66:in `split': bad URI(is not URI?): "https://IPV6_ADDRESS:443/api" (URI::InvalidURIError) IPv6 address must be enclosed with square brackets. Closes: #1546 Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
ashie
approved these changes
Dec 18, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When FLUENT_FILTER_KUBERNETES_URL is not set, KUBERNETES_SERVICE_HOST and KUBERNETES_SERVICE_PORT are used as a fallback.
When applying such a fallback, it will fail on only IPv6 is available. It causes the following error:
/usr/local/lib/ruby/3.2.0/uri/rfc3986_parser.rb:66:in `split': bad
URI(is not URI?):
"https://IPV6_ADDRESS:443/api" (URI::InvalidURIError)
IPv6 address must be enclosed with square brackets.
Closes: #1546