Fix timezone for compat timesliced output plugins #1307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because instance variables are initialized with default value in "super"
|
@repeatedly Could you check this fix? |
|
@repeatedly ping |
|
I tested this patch with my configuration and it worked. |
tagomoris
deleted the
fix-timezone-for-compat-timesliced-output-plugins
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes #1300.
Instance variables defined via
config_paramare initialized with nil (if specified so) after change #1296.TimeSlicedOutput plugin compat layer wrongly sets instance variable before calling
super, and the values of these instance variable are overwritten bysuper.I fixed that problem, and wrote a test for it.