Add priority_key/facility_key options to in_syslog #1351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knqyf263
force-pushed
the
add_options
branch
2 times, most recently
from
ee2b534
to
e928ef8
Compare
|
in_tcp's |
|
@repeatedly Thanks for your feedback! |
knqyf263
changed the title
|
LGTM. |
|
Thanks! |
|
I will backport this feature to v0.12 so v0.12 is enough. |
|
OK! |
repeatedly
added a commit
that referenced
this pull request
Dec 14, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want that
priorityandfacilityare in event record.Currently, I use
fluent-plugin-record-reformerto extractpriorityandfacilityvalues from tags.However, these values have already been parsed in
in_syslogplugin.fluentd/lib/fluent/plugin/in_syslog.rb
Lines 172 to 173 in 406c2a1
I think it is useless to use another plugin for extracting
priorityandfacility.Then, I added
include_priority/facilityoptions to in_syslog.