out_forward: Support mutual TLS. fix #1879 #2187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Masahiro Nakagawa <repeatedly@gmail.com>
okkez
approved these changes
Nov 27, 2018
There was a problem hiding this comment.
I've confirmed the feature works well using the following sequence:
https://gist.github.com/okkez/2094444717e0c7adfe9b29c7f1c118ed
Do we need the documentation about mutual authentication and examples?
|
@okkez Yes but we need feedback from other users. |
|
No feedback but okkez confirmed the behaviour and this change doesn't break existing behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Masahiro Nakagawa repeatedly@gmail.com