Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log: Fix plugin logger ignores fluentd log event setting #2252

Merged
merged 3 commits into from
Jan 7, 2019

Conversation

repeatedly
Copy link
Member

No description provided.

Signed-off-by: Masahiro Nakagawa <repeatedly@gmail.com>
Signed-off-by: Masahiro Nakagawa <repeatedly@gmail.com>
@repeatedly repeatedly added bug Something isn't working v1 labels Jan 5, 2019
@repeatedly repeatedly self-assigned this Jan 5, 2019
@repeatedly repeatedly requested a review from okkez January 5, 2019 02:11
Sometimes test code uses non Log/PluginLogger object for capturing log.
Such object doesn't have log_event_enabled so skip for now.

Signed-off-by: Masahiro Nakagawa <repeatedly@gmail.com>
Copy link
Contributor

@okkez okkez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@repeatedly repeatedly merged commit d4bc4ee into master Jan 7, 2019
@repeatedly repeatedly deleted the fix-plugin-logger-and-id branch January 7, 2019 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants