Set system config variables explicitly #2674
Conversation
Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
Use @system_config via access the ivar not to expose ivar to supervisor Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
supervise is used in lib/command/fluentd.rb Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
…deprecated Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
ganmacs
force-pushed
the
set-system-config-variables-explicitly
branch
from
de4e220
to
75a37eb
Compare
test/plugin/test_in_monitor_agent.rb
Outdated
| s = Fluent::Supervisor.new(opts.merge(config_path: filepath)) | ||
| s.configure | ||
| ensure | ||
| FileUtils.rm_r(CONFIG_DIR) rescue StandardError |
There was a problem hiding this comment.
what does 'rescue StandardError' mean?
There was a problem hiding this comment.
In order to resue Errno::ENOENT which happens when directory doesn't exist.
There was a problem hiding this comment.
Your code means rescue returns StandardError, not catch StandardError.
There was a problem hiding this comment.
oh… I misunderstood something………… 29fd4d7
| end | ||
|
|
||
| def change_privilege | ||
| ServerEngine::Privilege.change(@chuser, @chgroup) | ||
| end | ||
|
|
||
| def init_engine(supervisor: false) | ||
| def init_engine | ||
| Fluent::Engine.init(@system_config) |
There was a problem hiding this comment.
init_engine is now only one line. Can we replace init_engine with Fluent::Engine.init?
There was a problem hiding this comment.
I left it a method because others such as Supervisor#change_privilege, Supervisor#run_configure, Supervisor#run_engine are the same situation.
Do you think it's better to change these methods at this time? (I don't have a strong opinion about it. so if you have any opinion, I follow yours)
There was a problem hiding this comment.
I see. So it should be in other patch for refactor methods.
Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
Which issue(s) this PR fixes:
Ref #2624
What this PR does / why we need it:
Use
@system_configexplicitly so that supervisor doesn't need to expose all context to system_config. the current implementation is hard to understand since there are too many states.Docs Changes:
no need
Release Note:
no need