server helper: Fix IPv6 dual stack mode issue for tcp socket. #2697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Masahiro Nakagawa <repeatedly@gmail.com>
|
Don't you add a test for this? |
Signed-off-by: Masahiro Nakagawa <repeatedly@gmail.com>
Signed-off-by: Masahiro Nakagawa <repeatedly@gmail.com>
|
Just added test. |
ganmacs
approved these changes
Nov 15, 2019
lib/fluent/plugin_helper/server.rb
Outdated
| @@ -355,7 +355,11 @@ def server_create_tcp_socket(shared, bind, port) | |||
| sock = if shared | |||
| server_socket_manager_client.listen_tcp(bind, port) | |||
| else | |||
| TCPServer.new(bind, port) # this method call can create sockets for AF_INET6 | |||
| # TCPServer.new doesn't set IPV6_V6ONLY flag, so use Addrinfo class instead. | |||
| # backlog will be set correctly so use listen's default here | |||
There was a problem hiding this comment.
backlog will be set correctly
What does this mean? who sets backlog?
There was a problem hiding this comment.
server_create_tcp_socket is used in other API, e.g. server_create, and such APIs set backlog from plugins.
There was a problem hiding this comment.
This one? https://github.com/fluent/fluentd/blob/master/lib/fluent/plugin_helper/server.rb#L222
How about "backlog will be set by the caller, we don't set backlog here", then? (it's IMO. so it's ok for me to leave as it is)
Signed-off-by: Masahiro Nakagawa <repeatedly@gmail.com>
repeatedly
force-pushed
the
fix-dual-stack-ipv6-issue
branch
from
d04d397
to
29b5176
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Masahiro Nakagawa repeatedly@gmail.com
Which issue(s) this PR fixes:
Fixes #2682
What this PR does / why we need it:
Use other socket method to set
IPV6_V6ONLY.See also treasure-data/serverengine#101
Docs Changes:
No need
Release Note:
Same as title