output: Show better message for different secondary type #2751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Masahiro Nakagawa <repeatedly@gmail.com>
ganmacs
reviewed
Dec 27, 2019
| @@ -387,7 +387,7 @@ def configure(conf) | |||
| @secondary.acts_as_secondary(self) | |||
| @secondary.configure(secondary_conf) | |||
| if (self.class != @secondary.class) && (@custom_format || @secondary.implement?(:custom_format)) | |||
| log.warn "secondary type should be same with primary one", primary: self.class.to_s, secondary: @secondary.class.to_s | |||
| log.warn "Use different plugin for secondary. Check the plugin works with primary like secondary_file", primary: self.class.to_s, secondary: @secondary.class.to_s | |||
There was a problem hiding this comment.
I have two questions.
- Why this warning is needed? if it won't work, I think it should be error.
- How to check this? > Check the plugin works with primary like secondary_file
There was a problem hiding this comment.
Why this warning is needed? if it won't work, I think it should be error.
How to check this? > Check the plugin works with primary like secondary_file
Hard to reject the plugin by fluentd side because it depends on implementation issue.
If users can't judge the plugin works as secondary, users should use primary plugin or secondary_file.
ganmacs
approved these changes
Jan 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Masahiro Nakagawa repeatedly@gmail.com
Which issue(s) this PR fixes:
No issue in this repository.
What this PR does / why we need it:
Current message is bit misleading for users. Some output plugins work with primary.
Docs Changes:
No need for now.
Release Note:
Same as title.