Support Ruby's Time class in msgpack serde #2775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent msgpack-ruby can (de)serialize Time class. Add enable_msgpack_time_support parameter to system config for this feature. This is useful for multiple time fields. Signed-off-by: Masahiro Nakagawa <repeatedly@gmail.com>
ganmacs
approved these changes
Jan 14, 2020
cosmo0920
reviewed
Jan 14, 2020
| @@ -70,9 +70,15 @@ def self.unpacker(*args) | |||
| factory.unpacker(*args) | |||
| end | |||
|
|
|||
| def self.init | |||
| def self.init(enable_time_support: false) | |||
There was a problem hiding this comment.
Should we register MessagePack::Timestamp::TYPE in self.factory as well? Or it needn't to be registered there? 🤔
There was a problem hiding this comment.
Ah, I forgot self.factory because it is used in only tests...
Signed-off-by: Masahiro Nakagawa <repeatedly@gmail.com>
|
Applied reviews. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Masahiro Nakagawa repeatedly@gmail.com
Which issue(s) this PR fixes:
No issue.
What this PR does / why we need it:
Recent msgpack-ruby can (de)serialize Time class.
Add
enable_msgpack_time_supportparameter to system config for this feature.This is useful for multiple time fields.
See also: https://github.com/msgpack/msgpack-ruby#serializing-and-deserializing-time-instances
fluentd v2 will enable this feature by default.
Docs Changes:
Will add
enable_msgpack_time_supportto system config article after merged the patch.Release Note:
Same as title.