test_child_process: Try to fix unstable tests #3787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashie
force-pushed
the
try-to-fix-unstable-child-process-tests
branch
from
06f59bd
to
6ff5fd9
Compare
On CI environment, these tests sometimes observe unexepected 3rd command invocation due to delayed shutdown: ``` 2022-06-13T23:57:56.4703110Z Failure: test: can execute external command many times, with leading once executed immediately(ChildProcessTest) 2022-06-13T23:57:56.4704700Z /Users/runner/work/fluentd/fluentd/test/plugin_helper/test_child_process.rb:345:in `block (2 levels) in <class:ChildProcessTest>' 2022-06-13T23:57:56.4705540Z 342: end 2022-06-13T23:57:56.4706110Z 343: sleep 1.9 # 1sec(second invocation) + 0.9sec 2022-06-13T23:57:56.4706880Z 344: @d.stop; @d.shutdown; @d.close; @d.terminate 2022-06-13T23:57:56.4707620Z => 345: assert_equal 2, ary.size 2022-06-13T23:57:56.4708220Z 346: assert_equal [], @d.log.out.logs 2022-06-13T23:57:56.4708800Z 347: end 2022-06-13T23:57:56.4709330Z 348: end 2022-06-13T23:57:56.4709970Z /Users/runner/hostedtoolcache/Ruby/2.7.6/x64/lib/ruby/2.7.0/timeout.rb:95:in `block in timeout' 2022-06-13T23:57:56.4710800Z /Users/runner/hostedtoolcache/Ruby/2.7.6/x64/lib/ruby/2.7.0/timeout.rb:33:in `block in catch' 2022-06-13T23:57:56.4711540Z /Users/runner/hostedtoolcache/Ruby/2.7.6/x64/lib/ruby/2.7.0/timeout.rb:33:in `catch' 2022-06-13T23:57:56.4712240Z /Users/runner/hostedtoolcache/Ruby/2.7.6/x64/lib/ruby/2.7.0/timeout.rb:33:in `catch' 2022-06-13T23:57:56.4712940Z /Users/runner/hostedtoolcache/Ruby/2.7.6/x64/lib/ruby/2.7.0/timeout.rb:110:in `timeout' 2022-06-13T23:57:56.4713660Z /Users/runner/work/fluentd/fluentd/test/plugin_helper/test_child_process.rb:339:in `block in <class:ChildProcessTest>' 2022-06-13T23:57:56.4714530Z <2> expected but was 2022-06-13T23:57:56.4715340Z <3> ``` To avoid it, check only 1st & 2nd elapsed time. Signed-off-by: Takuro Ashie <ashie@clear-code.com>
ashie
force-pushed
the
try-to-fix-unstable-child-process-tests
branch
from
6ff5fd9
to
60417a9
Compare
1 task
This was referenced Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On CI environment, these tests sometimes observe unexepected 3rd command
invocation due to delayed shutdown:
To avoid it, check only 1st & 2nd elapsed time.
Signed-off-by: Takuro Ashie ashie@clear-code.com
Which issue(s) this PR fixes:
Fixes #
What this PR does / why we need it:
Docs Changes:
Release Note: