Suppress warnings step 2 #890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/fluent/config/configure_proxy.rb:256: warning: assigned but unused variable - opts
lib/fluent/plugin/in_tail.rb:692: warning: assigned but unused variable - pos lib/fluent/plugin/in_tail.rb:693: warning: assigned but unused variable - ino
lib/fluent/plugin/out_exec_filter.rb:117: warning: assigned but unused variable - localtime lib/fluent/plugin/out_exec_filter.rb:119: warning: assigned but unused variable - utc lib/fluent/plugin/out_exec_filter.rb:356: warning: assigned but unused variable - pid
* Remove unused variables test/plugin_helper/test_child_process.rb:95: warning: assigned but unused variable - t1 test/plugin_helper/test_child_process.rb:128: warning: assigned but unused variable - t1 test/plugin_helper/test_child_process.rb:165: warning: assigned but unused variable - t1 test/plugin_helper/test_child_process.rb:200: warning: assigned but unused variable - t1 test/plugin_helper/test_child_process.rb:236: warning: assigned but unused variable - t1 test/plugin_helper/test_child_process.rb:351: warning: assigned but unused variable - ary test/plugin_helper/test_child_process.rb:391: warning: assigned but unused variable - data test/plugin_helper/test_child_process.rb:379: warning: assigned but unused variable - ary test/plugin_helper/test_child_process.rb:445: warning: assigned but unused variable - encodings test/plugin_helper/test_child_process.rb:467: warning: assigned but unused variable - encodings test/plugin_helper/test_child_process.rb:489: warning: assigned but unused variable - encodings * Add '_' prefix to block variable test/plugin_helper/test_child_process.rb:512: warning: shadowing outer local variable - io test/plugin_helper/test_child_process.rb:529: warning: shadowing outer local variable - io
test/plugin/test_out_file.rb:252: warning: File.exists? is a deprecated name, use File.exist? instead test/plugin/test_out_file.rb:257: warning: File.exists? is a deprecated name, use File.exist? instead
* Use File.exist? instead of File.exist? test/plugin/test_buf_file.rb:90: warning: File.exists? is a deprecated name, use File.exist? instead test/plugin/test_buf_file.rb:103: warning: File.exists? is a deprecated name, use File.exist? instead test/plugin/test_buf_file.rb:42: warning: File.exists? is a deprecated name, use File.exist? instead test/plugin/test_buf_file.rb:212: warning: File.exists? is a deprecated name, use File.exist? instead test/plugin/test_buf_file.rb:213: warning: File.exists? is a deprecated name, use File.exist? instead test/plugin/test_buf_file.rb:217: warning: File.exists? is a deprecated name, use File.exist? instead test/plugin/test_buf_file.rb:218: warning: File.exists? is a deprecated name, use File.exist? instead test/plugin/test_buf_file.rb:409: warning: File.exists? is a deprecated name, use File.exist? instead test/plugin/test_buf_file.rb:416: warning: File.exists? is a deprecated name, use File.exist? instead test/plugin/test_buf_file.rb:417: warning: File.exists? is a deprecated name, use File.exist? instead test/plugin/test_buf_file.rb:381: warning: File.exists? is a deprecated name, use File.exist? instead test/plugin/test_buf_file.rb:387: warning: File.exists? is a deprecated name, use File.exist? instead test/plugin/test_buf_file.rb:388: warning: File.exists? is a deprecated name, use File.exist? instead test/plugin/test_buf_file.rb:347: warning: File.exists? is a deprecated name, use File.exist? instead * Use Dir.exist? instead of Dir.exists? test/plugin/test_buf_file.rb:334: warning: Dir.exists? is a deprecated name, use Dir.exist? instead test/plugin/test_buf_file.rb:336: warning: Dir.exists? is a deprecated name, use Dir.exist? instead
lib/fluent/plugin_helper/timer.rb:39: warning: instance variable @_timer_running not initialized lib/fluent/plugin_helper/timer.rb:39: warning: instance variable @_timer_running not initialized
lib/fluent/plugin/in_tail.rb:175: warning: instance variable @pf not initialized lib/fluent/plugin/in_tail.rb:122: warning: instance variable @pf_file not initialized
|
See also #848 |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.