Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#772] Support multiline string in " quoted string #929

Merged

Conversation

llby
Copy link
Contributor

@llby llby commented May 2, 2016

Support multiline string in " quoted string

@repeatedly
Copy link
Member

Thx! I will check it later.

@repeatedly repeatedly self-assigned this May 2, 2016
@llby
Copy link
Contributor Author

llby commented May 2, 2016

Wait! Wait!
I got another simple way.
Please wait!

@llby
Copy link
Contributor Author

llby commented May 2, 2016

@repeatedly I got another simple way.

@repeatedly
Copy link
Member

It seems good.

@tagomoris @sonots Do you have any concern? Tests are passed so it seems no breaking compatibility.

@sonots
Copy link
Member

sonots commented May 10, 2016

LGTM

@tagomoris
Copy link
Member

LGTM!

@repeatedly repeatedly merged commit 0d05606 into fluent:master May 10, 2016
@repeatedly
Copy link
Member

Thx!

@llby
Copy link
Contributor Author

llby commented May 10, 2016

Hyahhooooo!!!
Thanks a lot!!!
Next I'll try to the 「Add include support for Ruby DSL」

@llby llby deleted the support-multiline-string-in-quoted-string branch May 10, 2016 12:44
@repeatedly repeatedly added v0.12 enhancement Feature request or improve operations v0.14 labels May 16, 2016
repeatedly added a commit that referenced this pull request May 20, 2016
…string

[#772]  Support multiline string in " quoted string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request or improve operations v0.12 v0.14
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants