Fix overwriting config_section definitions: #981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tagomoris
force-pushed
the
fix-config_section-overwriting
branch
from
6c913e8
to
59baea9
Compare
* "name" and "param_name" is strongly connected with plugin's code (even in base classes) so these MUST be not changed by subclasses (subclass MUST use same names) * separate "param_name" from "name" to detect overwriting "param_name" by subclasses to raise errors and add "variable_name" method as internal utility * make it possible to change default values in finalized sections because it's very popular that 3rd party plugin prefer different default value for built-in predefined parameters * make it possible to change "init" specification of finalized sections because newly added/changed default values might be able to init sections
tagomoris
force-pushed
the
fix-config_section-overwriting
branch
from
59baea9
to
852d5b1
Compare
|
@repeatedly @sonots I'll merge this later if there's no objection. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so these MUST be not changed by subclasses (subclass MUST use same names)
and add "variable_name" method as internal utility
because it's very popular that 3rd party plugin prefer different default value for built-in predefined parameters
because newly added/changed default values might be able to init sections