-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FailureMessage.Err method and AssertionError type #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pellared
reviewed
Sep 8, 2024
pellared
reviewed
Sep 8, 2024
I like the suggest changes. I implemented them by:
|
pellared
reviewed
Sep 9, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #141 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 15 16 +1
Lines 438 444 +6
=========================================
+ Hits 438 444 +6 ☔ View full report in Codecov by Sentry. |
Thanks for your contribution. I plan to make a release today. |
pellared
approved these changes
Sep 9, 2024
pellared
changed the title
Option to return an
Add FailureMessage.Err method and AssertionError type
Sep 10, 2024
error
from assertions instead of failing directly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Sometimes you want to get an
error
from an assertion rather than directly fail a test run. Also test suites like Godog rely on returning anerror
instead of directly failing tests (e.g. because they encapsulate direct access to the test instance).What
The
FailureMessage
type received a functionAsError()
that returns an instance oferror
or nil with the according failure message.Checklist
CHANGELOG.md
is updated.README.md
is updated.