Remove redundant admission webhook operation rule #2054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dongyun.xzh <dongyun.xzh@alibaba-inc.com>
Codecov Report
@@ Coverage Diff @@
## master #2054 +/- ##
=======================================
Coverage 53.40% 53.40%
=======================================
Files 291 291
Lines 20997 20997
=======================================
Hits 11214 11214
Misses 8562 8562
Partials 1221 1221 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
cheyang
approved these changes
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: dongyun.xzh dongyun.xzh@alibaba-inc.com
Ⅰ. Describe what this PR does
Remove redundant admission webhook operation rule. According to #2053, pod update will failed when fluid webhook injection is enabled.
This is because fluid webhook will be called when any pod update request is issued. For some of the webhook plugins(e.g.
PreferNodesWithoutCache), they attempt to mutate some immutable information in the pod, causing validation failure.Ⅱ. Does this pull request fix one issue?
fixes #2053
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews