Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Juicefs/fix secret key #2509

Merged

Conversation

zwwhdls
Copy link
Member

@zwwhdls zwwhdls commented Jan 11, 2023

Ⅰ. Describe what this PR does

fix #2508

Ⅱ. Does this pull request fix one issue?

fixes #XXXX

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: zwwhdls <zww@hdls.me>
Signed-off-by: zwwhdls <zww@hdls.me>
@zwwhdls
Copy link
Member Author

zwwhdls commented Jan 11, 2023

/test fluid-e2e

@codecov
Copy link

codecov bot commented Jan 11, 2023

Codecov Report

Merging #2509 (4a1f43e) into master (5cf584d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2509   +/-   ##
=======================================
  Coverage   67.48%   67.48%           
=======================================
  Files         367      367           
  Lines       21237    21241    +4     
=======================================
+ Hits        14331    14335    +4     
  Misses       5221     5221           
  Partials     1685     1685           
Impacted Files Coverage Δ
pkg/ddc/juicefs/transform_fuse.go 82.35% <100.00%> (+0.35%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cheyang
Copy link
Collaborator

cheyang commented Jan 11, 2023

/test fluid-e2e

@cheyang
Copy link
Collaborator

cheyang commented Jan 12, 2023

/lgtm
/approve

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Jan 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fluid-e2e-bot fluid-e2e-bot bot merged commit 80d4fbb into fluid-cloudnative:master Jan 12, 2023
cheyang pushed a commit to cheyang/fluid that referenced this pull request Feb 14, 2023
* fix key of secret

Signed-off-by: zwwhdls <zww@hdls.me>

* fix secretkey & update changelog

Signed-off-by: zwwhdls <zww@hdls.me>

Signed-off-by: zwwhdls <zww@hdls.me>
cheyang pushed a commit to cheyang/fluid that referenced this pull request Feb 18, 2023
* fix key of secret

Signed-off-by: zwwhdls <zww@hdls.me>

* fix secretkey & update changelog

Signed-off-by: zwwhdls <zww@hdls.me>

Signed-off-by: zwwhdls <zww@hdls.me>
cheyang pushed a commit to cheyang/fluid that referenced this pull request Feb 18, 2023
* fix key of secret

Signed-off-by: zwwhdls <zww@hdls.me>

* fix secretkey & update changelog

Signed-off-by: zwwhdls <zww@hdls.me>

Signed-off-by: zwwhdls <zww@hdls.me>
Signed-off-by: cheyang <cheyang@163.com>
cheyang pushed a commit to cheyang/fluid that referenced this pull request Feb 18, 2023
* fix key of secret

Signed-off-by: zwwhdls <zww@hdls.me>

* fix secretkey & update changelog

Signed-off-by: zwwhdls <zww@hdls.me>

Signed-off-by: zwwhdls <zww@hdls.me>
Signed-off-by: cheyang <cheyang@163.com>
cheyang pushed a commit to cheyang/fluid that referenced this pull request Feb 18, 2023
* fix key of secret

Signed-off-by: zwwhdls <zww@hdls.me>

* fix secretkey & update changelog

Signed-off-by: zwwhdls <zww@hdls.me>

Signed-off-by: zwwhdls <zww@hdls.me>
cheyang pushed a commit to cheyang/fluid that referenced this pull request Feb 18, 2023
* fix key of secret

Signed-off-by: zwwhdls <zww@hdls.me>

* fix secretkey & update changelog

Signed-off-by: zwwhdls <zww@hdls.me>

Signed-off-by: zwwhdls <zww@hdls.me>
Signed-off-by: cheyang <cheyang@163.com>
cheyang added a commit that referenced this pull request Feb 18, 2023
* fix key of secret



* fix secretkey & update changelog

Signed-off-by: zwwhdls <zww@hdls.me>
Signed-off-by: cheyang <cheyang@163.com>
Co-authored-by: Weiwei <zww@hdls.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] JuiceFSRuntime - error when credential key is not "secret-key"
2 participants