Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allocate metrics port for multi runtime #2669

Merged

Conversation

zwwhdls
Copy link
Member

@zwwhdls zwwhdls commented Feb 28, 2023

Ⅰ. Describe what this PR does

fix #2668

  1. enterprise edition dose not have metrics port
  2. allocate metrics port when pod using hostNetwork

Ⅱ. Does this pull request fix one issue?

fixes #XXXX

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: zwwhdls <zww@hdls.me>
Signed-off-by: zwwhdls <zww@hdls.me>
Signed-off-by: zwwhdls <zww@hdls.me>
Signed-off-by: zwwhdls <zww@hdls.me>
@zwwhdls
Copy link
Member Author

zwwhdls commented Mar 1, 2023

/test fluid-e2e

@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Merging #2669 (dd5970c) into master (cac476a) will decrease coverage by 0.07%.
The diff coverage is 56.03%.

❗ Current head dd5970c differs from pull request most recent head 1f0e506. Consider uploading reports for the commit 1f0e506 to get more accurate results

@@            Coverage Diff             @@
##           master    #2669      +/-   ##
==========================================
- Coverage   67.61%   67.54%   -0.07%     
==========================================
  Files         380      381       +1     
  Lines       21840    21953     +113     
==========================================
+ Hits        14767    14829      +62     
- Misses       5347     5385      +38     
- Partials     1726     1739      +13     
Impacted Files Coverage Δ
pkg/ddc/juicefs/shutdown.go 55.76% <0.00%> (-5.36%) ⬇️
pkg/ddc/juicefs/transform.go 61.20% <46.66%> (-9.63%) ⬇️
pkg/ddc/juicefs/port_parser.go 74.19% <74.19%> (ø)
pkg/ddc/juicefs/transform_fuse.go 78.96% <100.00%> (+0.51%) ⬆️
pkg/ddc/juicefs/utils.go 81.54% <100.00%> (+1.54%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cheyang
Copy link
Collaborator

cheyang commented Mar 1, 2023

/lgtm
/approve

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Mar 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fluid-e2e-bot fluid-e2e-bot bot merged commit de4644e into fluid-cloudnative:master Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [JuiceFS] FUSE pod scheduled failed because of conflict port
2 participants