Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change reinvocationPolicy to IfNeeded #3226

Conversation

cheyang
Copy link
Collaborator

@cheyang cheyang commented May 11, 2023

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

fixes #XXXX

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

lizzzcai and others added 2 commits May 11, 2023 16:12
Signed-off-by: cheyang <cheyang@163.com>
Signed-off-by: cheyang <cheyang@163.com>
@sonarcloud
Copy link

sonarcloud bot commented May 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Merging #3226 (ea6c4b8) into release-0.8 (31ec0db) will not change coverage.
The diff coverage is n/a.

❗ Current head ea6c4b8 differs from pull request most recent head e08d78f. Consider uploading reports for the commit e08d78f to get more accurate results

@@             Coverage Diff              @@
##           release-0.8    #3226   +/-   ##
============================================
  Coverage        68.30%   68.30%           
============================================
  Files              297      297           
  Lines            16966    16966           
============================================
  Hits             11588    11588           
  Misses            4127     4127           
  Partials          1251     1251           

@cheyang cheyang requested a review from TrafalgarZZZ May 11, 2023 11:41
Copy link
Member

@TrafalgarZZZ TrafalgarZZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@TrafalgarZZZ TrafalgarZZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented May 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TrafalgarZZZ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fluid-e2e-bot fluid-e2e-bot bot merged commit a1cfdda into fluid-cloudnative:release-0.8 May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants