fix default master journal type setting #3281
Conversation
|
Hi @VincentLeeMax. Thanks for your PR. I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Kudos, SonarCloud Quality Gate passed!
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheyang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@VincentLeeMax could you please fix DCO issue by following https://github.com/fluid-cloudnative/fluid/pull/3281/checks?check_run_id=14182631765 |
| @@ -66,7 +66,11 @@ func (e *AlluxioEngine) optimizeDefaultProperties(runtime *datav1alpha1.AlluxioR | |||
| setDefaultProperties(runtime, value, "alluxio.user.file.passive.cache.enabled", "false") | |||
| setDefaultProperties(runtime, value, "alluxio.user.block.avoid.eviction.policy.reserved.size.bytes", "2GB") | |||
| setDefaultProperties(runtime, value, "alluxio.master.journal.folder", "/journal") | |||
| setDefaultProperties(runtime, value, "alluxio.master.journal.type", "UFS") | |||
| if value.Master.Replicas > 1 { | |||
There was a problem hiding this comment.
If possible, could you please add unit test for this change? Thanks.
There was a problem hiding this comment.
If possible, could you please add unit test for this change? Thanks.
I don't know which file should the unit test write to, could you tell me?
Codecov Report
@@ Coverage Diff @@
## master #3281 +/- ##
==========================================
- Coverage 65.48% 65.47% -0.01%
==========================================
Files 397 397
Lines 23170 23173 +3
==========================================
Hits 15173 15173
- Misses 6214 6215 +1
- Partials 1783 1785 +2
|
Signed-off-by: cheyang <cheyang@163.com>
Ⅰ. Describe what this PR does
In default setting, the
alluxio.master.journal.typewill set toUFS, causing the HA mode fail. Now we change the default setting according to the master replicas.Ⅳ. Describe how to verify it
Deploy a HA alluxio dataset, delete the leading master pod, you will see: