-
Notifications
You must be signed in to change notification settings - Fork 961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: sort broken mountpoint and put subpaths at the end. #4423
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: SimonCqk <cqk0100@gamil.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @SimonCqk. Thanks for your PR. I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4423 +/- ##
==========================================
- Coverage 58.22% 58.20% -0.02%
==========================================
Files 565 565
Lines 30967 30982 +15
==========================================
+ Hits 18030 18034 +4
- Misses 10745 10755 +10
- Partials 2192 2193 +1 ☔ View full report in Codecov by Sentry. |
@@ -64,14 +69,15 @@ func getGlobalMounts(mountByPath map[string]*Mount) (globalMountByName map[strin | |||
|
|||
for k, v := range mountByPath { | |||
if strings.Contains(k, mountRoot) { | |||
vCopy := v |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think vCopy := v does not create a deep copy of the Mount object; instead, it creates a new pointer to the same Mount object. If the original Mount object is modified, vCopy will reflect these changes. If this behavior is not intended, implementing a method for deep copying might be necessary.
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
fixes #XXXX
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews