Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Resolve the PreStartHook failure caused by the slow startup of fuse container #4454

Conversation

Syspretor
Copy link
Collaborator

@Syspretor Syspretor commented Dec 23, 2024

Fixes #4455
The following postStartHook will be injected in the fuse-sidecar to check the mount status.

lifecycle:
  postStart:
    exec:
      command: [ "/bin/sh", "-c", "time /check-mount.sh >> /proc/1/fd/1" ]

However, the startup of the Container and the execution of the PostStartHook occur in parallel. it is possible that when the PostStartHook is executed, the PID 1 process inside the container has not completed its startup. This can lead to a failure in redirecting to /proc/1/fd/1 when the PostStartHook runs the check-mount script.

Copy link

fluid-e2e-bot bot commented Dec 23, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign yangyuliufeng for approval by writing /assign @yangyuliufeng in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Syspretor Syspretor assigned cheyang and unassigned cheyang Dec 23, 2024
@Syspretor Syspretor requested a review from cheyang December 23, 2024 11:35
Signed-off-by: jiuyu <guotongyu.gty@alibaba-inc.com>
@Syspretor Syspretor closed this Dec 23, 2024
@Syspretor Syspretor force-pushed the fix/resolve-postStartHook-failed branch from 88810f4 to 8c5b52c Compare December 23, 2024 11:42
@Syspretor Syspretor changed the title [WIP] resolve the PreStartHook failure caused by the /proc/1/fd/1 not exists [WIP] Resolve the PreStartHook failure caused by the slow startup of fuse container Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants