Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: push/browser notifications #129

Closed
imrcly opened this issue Jan 31, 2021 · 7 comments
Closed

FR: push/browser notifications #129

imrcly opened this issue Jan 31, 2021 · 7 comments
Assignees
Labels
FR - Enhancement New feature or request GH - WontFix This will not be worked on UI - QoL Improvements to the UI
Milestone

Comments

@imrcly
Copy link

imrcly commented Jan 31, 2021

Browser notification when a print completes/error stops

Tried to find this in vueify for desktop browser but did find it as an html standard https://developer.mozilla.org/en-US/docs/Web/API/Notification
and as a push notification view for vue on mobile devices https://vuejsexamples.com/a-library-for-previewing-push-notification-with-vue/

@cadriel cadriel added the FR - Enhancement New feature or request label Jan 31, 2021
@cadriel
Copy link
Member

cadriel commented Jan 31, 2021

I've been hesitant to implement this in the past, due to a lot of users usually blocking browser based notifications - or them not being well integrated with the OS.

@jtkDvlp
Copy link

jtkDvlp commented Feb 1, 2021

It would be nice to get notifications on mobile via Progressive Web App architecture

@cadriel
Copy link
Member

cadriel commented Feb 2, 2021

Fluidd is already a PWA. The notifications themselves are another story.. I'll look into them a bit more in an upcoming update.

@jtkDvlp
Copy link

jtkDvlp commented Feb 2, 2021

If desired please give a little developer overivew / intro documentation and I offer my help :-)

@StuSerious StuSerious added this to the Fluidd Next milestone Sep 6, 2021
@StuSerious StuSerious added the UI - Mobile All matters related to the mobile UI label Jan 30, 2022
@StuSerious StuSerious moved this to Long Term in Roadmap Jan 30, 2022
@pedrolamas pedrolamas modified the milestones: Fluidd Next, Release: 1.18 Feb 25, 2022
@matmen matmen self-assigned this Mar 13, 2022
@matmen matmen changed the title push/browser Notification FR: push/browser notifications Mar 14, 2022
@matmen
Copy link
Member

matmen commented Mar 14, 2022

I've started implementing this, but we are running into a couple issues here:

  • Chrome and Firefox no longer allow notifications to be instantiated from insecure origins (meaning only HTTPS is supported)
  • To support secure origins, Moonraker will have to be served over HTTPS too to prevent mixed content
  • I believe audio cues (as suggested in Audio Cues for printer paused and finished in browser #520) also won't work because playing sound requires user interaction

Because of those reasons, deploying this is currently blocked (as it would only work for localhost or setups with both Fluidd and Moonraker being served over HTTPS). I'll move this to the backlog and keep you updated if anything changes.

@matmen matmen added UI - QoL Improvements to the UI and removed UI - Mobile All matters related to the mobile UI labels Mar 14, 2022
@matmen matmen modified the milestones: 1.18, vNext Mar 14, 2022
@matmen matmen removed this from Tracker May 9, 2022
@matmen matmen removed this from Roadmap May 9, 2022
@pedrolamas
Copy link
Member

Given the technical requirements for in-browser notifications to work (specifically, HTTPS), I don't see this moving forward anytime soon.

I would recommend that instead, users just use the existing Moonraker notifier support: https://moonraker.readthedocs.io/en/latest/configuration/#notifier

@pedrolamas pedrolamas added the GH - WontFix This will not be worked on label Jul 18, 2022
@matmen
Copy link
Member

matmen commented Jul 19, 2022

I'll go ahead and close this for now, considering there already are alternatives. I do agree however that in-browser notifications would be nice to have, so we most likely will revisit this once we have the prerequisites for it implemented.

@matmen matmen closed this as not planned Won't fix, can't repro, duplicate, stale Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FR - Enhancement New feature or request GH - WontFix This will not be worked on UI - QoL Improvements to the UI
Projects
None yet
Development

No branches or pull requests

6 participants