Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio Cues for printer paused and finished in browser #520

Closed
mrfloppy88 opened this issue Feb 13, 2022 · 7 comments
Closed

Audio Cues for printer paused and finished in browser #520

mrfloppy88 opened this issue Feb 13, 2022 · 7 comments
Assignees
Labels
FR - Enhancement New feature or request UI - QoL Improvements to the UI
Milestone

Comments

@mrfloppy88
Copy link

Is your feature request related to a problem? Please describe

when printer goes in pause because of fillament runout or a M600 and printer is not near the user watching on browser
it can go by unnoticed and ruin some prints

Describe the solution you'd like

upload sound files or pick between built in sounds to play when printer is done or paused

Describe alternatives you've considered

No response

Additional information

No response

@matmen matmen added FR - Enhancement New feature or request UI - QoL Improvements to the UI labels Feb 16, 2022
@pedrolamas
Copy link
Member

Indeed, this can be added to Fluidd or any other Klipper interface, but I do wonder if using the native support in Klipper isn't a preferred method (as that will work even if no graphical interface is connected!)

In the case of Fluidd, for this to work it would mean that you have a computer with the browser pointing to Fluidd and that the audio is not mute... 🤔

@matmen
Copy link
Member

matmen commented Feb 18, 2022

The buzzer won't work for some users (me included), my printer isn't in the same room as me so I can't hear it. I do think having a browser notification sound would be useful, for me Fluidd is constantly open while printing anyway.

@pedrolamas
Copy link
Member

pedrolamas commented Feb 18, 2022

That's a fair point... given that, I wonder if we shouldn't just look into browser notifications instead and let the host Browser/OS handle it for us!

image

If we go this way, we might just use the vue-native-notification to help out!

@Biorn1950
Copy link
Contributor

I'm agree with @pedrolamas we must use the native notification.

@matmen matmen added this to the Release: 1.18 milestone Feb 22, 2022
@matmen
Copy link
Member

matmen commented Feb 25, 2022

Related: #129

@kthornbloom
Copy link

I started toying with this by adding

/* eslint-disable */
  @Watch('estimates.progress', { immediate: true }) onMatchChanged () {
      var progressPercent = parseInt(this.estimates.progress)
      if(progressPercent === 100){
        const greeting = new Notification ('FLUIDD', { body: 'Operation Completed' })
      }
  }

  mounted () {
    if (Notification.permission !== 'granted') {
      Notification.requestPermission()
    }
  }

to statustab.vue. Works well, but needs more tweaks to know if the job just completed vs a page refresh. Unfortunately, as a vanilla JS guy, all this typescript + hardcore linting is killing my soul 😄

@matmen matmen self-assigned this Mar 13, 2022
@matmen
Copy link
Member

matmen commented Mar 14, 2022

Closing in favor of #129

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FR - Enhancement New feature or request UI - QoL Improvements to the UI
Projects
None yet
Development

No branches or pull requests

5 participants