Bug when updating lines with a new color

[antonovttm]

Hi there.

I believe this is a bug. When I create a line with addLine on my first state, everything works fine, but after I try to edit it with updateLine and try to give it a new color or even the same color, I get the following error and the map stops drawing lines:

E/Convert (28412): setLineOpacity0.5
E/Convert (28412): setLineColor#000000
E/MethodChannel#plugins.flutter.io/mapbox_maps_0(28412): Failed to handle method call
E/MethodChannel#plugins.flutter.io/mapbox_maps_0(28412): com.mapbox.mapboxsdk.exceptions.ConversionException: Not a valid rgb/rgba value
E/MethodChannel#plugins.flutter.io/mapbox_maps_0(28412): 	at com.mapbox.mapboxsdk.utils.ColorUtils.rgbaToColor(ColorUtils.java:138)
E/MethodChannel#plugins.flutter.io/mapbox_maps_0(28412): 	at com.mapbox.mapboxgl.LineController.setLineColor(LineController.java:58)
E/MethodChannel#plugins.flutter.io/mapbox_maps_0(28412): 	at com.mapbox.mapboxgl.Convert.interpretLineOptions(Convert.java:470)
E/MethodChannel#plugins.flutter.io/mapbox_maps_0(28412): 	at com.mapbox.mapboxgl.MapboxMapController.onMethodCall(MapboxMapController.java:736)
E/MethodChannel#plugins.flutter.io/mapbox_maps_0(28412): 	at io.flutter.plugin.common.MethodChannel$IncomingMethodCallHandler.onMessage(MethodChannel.java:233)
E/MethodChannel#plugins.flutter.io/mapbox_maps_0(28412): 	at io.flutter.embedding.engine.dart.DartMessenger.handleMessageFromDart(DartMessenger.java:85)
E/MethodChannel#plugins.flutter.io/mapbox_maps_0(28412): 	at io.flutter.embedding.engine.FlutterJNI.handlePlatformMessage(FlutterJNI.java:692)
E/MethodChannel#plugins.flutter.io/mapbox_maps_0(28412): 	at android.os.MessageQueue.nativePollOnce(Native Method)
E/MethodChannel#plugins.flutter.io/mapbox_maps_0(28412): 	at android.os.MessageQueue.next(MessageQueue.java:336)
E/MethodChannel#plugins.flutter.io/mapbox_maps_0(28412): 	at android.os.Looper.loop(Looper.java:174)
E/MethodChannel#plugins.flutter.io/mapbox_maps_0(28412): 	at android.app.ActivityThread.main(ActivityThread.java:7356)
E/MethodChannel#plugins.flutter.io/mapbox_maps_0(28412): 	at java.lang.reflect.Method.invoke(Native Method)
E/MethodChannel#plugins.flutter.io/mapbox_maps_0(28412): 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:491)
E/MethodChannel#plugins.flutter.io/mapbox_maps_0(28412): 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:940)

[AAverin]

This happens because https://github.com/tobrun/flutter-mapbox-gl/blob/9ee6d315b6154ad507cad6e20d7efb437feb8889/android/src/main/java/com/mapbox/mapboxgl/LineController.java#L61
LineController works different to LineBuilder and tries to parse color in a format of rgba(1,2,3,4) which doesn't match the initial Color that we pass into line

[lomza]

I have converted hex color string to rgba(r,g,b,a) one and it worked in 0.13.0 and in the last version of the library (0.14.0) it doesn't work anymore, with com.mapbox.mapboxsdk.exceptions.ConversionException: Not a valid rgb/rgba value error showing again. So, what is the correct format now?

[AAverin]

@lomza I don't see any changes related to how colors work.
Both LineController in this repo and ColorUtils in original Android Mapbox SDK didn't change, you can see implementation here, maybe it will give you some ideas?

https://github.com/mapbox/mapbox-gl-native-android/blob/545884af52baa2d36f866a596741d5af7abdc9d5/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/utils/ColorUtils.java#L126

[lomza]

You're right, @AAverin , for Android I still need to provide rgba color string, doesn't matter if 0.13.0 or 0.14.0 version. They only changed line.setLineColor(ColorUtils.rgbaToColor(lineColor)); to line.setLineColor(Color.parseColor(lineColor));

FYI, for iOS hex is enough.

If somebody seeks a solution, this is my working code:

var color;
if (Platform.isAndroid) {
          color = ColorParser('#858AEE').toRgbaString();
        } else {
          color = '#858AEE';
        }
        await controller.updateLine(
          element,
          LineOptions(lineColor: color),
        );

I use ColorParser from fff library

[AAverin]

@lomza Where is this change exactly?
In https://github.com/flutter-mapbox-gl/maps/blob/master/android/src/main/java/com/mapbox/mapboxgl/LineController.java I still see rgbaToColor used.

[lomza]

I though that this merge was done maplibre/flutter-maplibre-gl#15 , but seems it didn't.

[AAverin]

@m0nac0 Should we bring that fix into main repo?

[m0nac0]

@vberthet Would you like to bring your fix over to this repo?

(Should be straightforward by cherry-picking)

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.