-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handled methods camera#move and camera#animate #30
Conversation
[ios] handled method map#update
deleted MapboxGLFactory.swift
@andrea689 thanks again for contributing! Could you send me an email? would love to setup collaborator rights for you so you can push directly to this repository.
zoomBy is zooming with a specific amount of zoom and focus is using a focal point (a x,y position on screen). The iOS SDK will have a functionality available where you can convert a x,y positon on screen to a LatLng, this value together with the zoom can be used to calculate a new camera position. Note that the concept of zoom on Android is very different than the altitude on the iOS SDK. We will need to find a conversion for it. (I have pinged the Mapbox iOS team for it). |
@andrea689 capturing from an iOS engineer working on the maps SDK, you can use: |
@tobrun thanks for the opportunity, I send you an email. |
correct, we can actually opt to not expose. I don't feel this is a highly needed feature. Can you remove it from the flutter and android code? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andrea689 was finally able to get my iOS dev. env. working. I had to export SWIFT_VERSION=3 as env. variable. I took this PR for a spin and is already looking good! tiltTo doesn't seem to be doing anything, the zoomBy with focus can be removed.
@tobrun in the example, |
[ios] implemented zoomBy with focus
@andrea689 would you be able to rebase this branch?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
* first iOS implementation * [ios] handled method map#waitForMap * [ios] added interpretation of MapboxOptions and initial configuration [ios] handled method map#update * added SWIFT_VERSION to Podfile deleted MapboxGLFactory.swift * [ios] handled methods camera#move and camera#animate * corrected README * [ios] fixed y coordinate from scrollBy [ios] implemented zoomBy with focus
I don't know how to handle 'zoomBy with focus'
You have some ideas?