Add line annotations #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Re. annotation click handling and having support for more types, in the Circle PR, I'm using the base AnnotationClick to support this https://github.com/tobrun/flutter-mapbox-gl/pull/37/files#diff-5def2a7288f868311179d4a318f1183dR453 |
|
Thanks, @tobrun ! I added onLineTapped. Can you please review? |
tobrun
reviewed
Mar 27, 2019
(example could be expanded a bit but let's revisit that later)
tobrun
approved these changes
Mar 27, 2019
tobrun
reviewed
Mar 27, 2019
| } | ||
| final List<?> data = toList(o); | ||
| List<LatLng> latLngList = new ArrayList<>(); | ||
| data.forEach((element) -> { |
There was a problem hiding this comment.
Call requires API level 24?
There was a problem hiding this comment.
Thanks! I changed it to a for loop.
SheaSmith
pushed a commit
to SheaSmith/flutter-mapbox-gl
that referenced
this pull request
Sep 15, 2019
* Add line Annotations * add line properties to examples * Add onLineTapped * change forEach to for * fix error in merge * fix methods order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some examples are still missing, as well as a line onClick event.