Invert iOS compassView.isHidden logic #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@philiplindberg could you add a bit more context to this PR? cc @andrea689 |
|
Updated the PR description, see above. |
andrea689
approved these changes
Apr 20, 2019
SheaSmith
pushed a commit
to SheaSmith/flutter-mapbox-gl
that referenced
this pull request
Sep 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the map compass is enabled (which it should be by default),
mapView.compassView.isHiddenshould be set to the inverse ofcompassEnabled(line 128 of ios/Classes/MapboxMapController.swift). Right now,mapView.compassView.isHiddenis set to the value ofcompassEnabled, which hides the compass when it should be visible.