Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/771 ios onstyleready reliability #775

Conversation

AAverin
Copy link
Contributor

@AAverin AAverin commented Nov 18, 2021

Looking into report in #771, this PR applies proposed by @felix-ht change to improve onStyleReadyCallback reliability on iOS

@felix-ht
Copy link
Collaborator

felix-ht commented Nov 18, 2021

Does this also fix the original issue you were seeing?

Saw your other comment on #771 - LGTM

@AAverin
Copy link
Contributor Author

AAverin commented Nov 18, 2021

@felix-ht Do you know if there is anything I should do for builds to pass?

@felix-ht
Copy link
Collaborator

@AAverin no idea seems to be failing for all buids atm

@m0nac0
Copy link
Collaborator

m0nac0 commented Nov 19, 2021

Regarding the build failure: I've encountered something similar in the past, and I'm nearly certain it's because of a malformed .netrc file. Maybe the SDK_REGISTRY_TOKEN is not found and therefore empty?
That would explain the error: the netrc file ends unexpectedly after "password" without any actual password.

@AAverin
Copy link
Contributor Author

AAverin commented Nov 19, 2021

@m0nac0 .netrc is only used on iOS but Android also seems to fail. Probably some mistake in CI configuration

@AAverin
Copy link
Contributor Author

AAverin commented Nov 19, 2021

@tobrun Could you please take a look at what is in Settings => Secrets? Might be ANDROID_CI_DOWNLOADS_TOKEN property is not set

@m0nac0
Copy link
Collaborator

m0nac0 commented Nov 19, 2021

@m0nac0 .netrc is only used on iOS but Android also seems to fail. Probably some mistake in CI configuration

Right. That message is even clearer regarding the missing SDK_REGISTRY_TOKEN

@tobrun
Copy link
Collaborator

tobrun commented Nov 20, 2021

Confirmed in #783 through github action run that the token is not shared to PRs coming from forks. This doesn't seem configurable, I will try finding a solution for it.

This all said, if you are part of the @flutter-mapbox-gl/team, please use a direct clone of the repo instead of forking.
Most of the PRs do come from this select group :)

@tobrun tobrun merged commit 5d9a5c7 into flutter-mapbox-gl:master Nov 20, 2021
m0nac0 added a commit to maplibre/flutter-maplibre-gl that referenced this pull request May 15, 2022
https: //github.com/flutter-mapbox-gl/maps/pull/775
Co-Authored-By: Anton Averin <1481332+AAverin@users.noreply.github.com>
m0nac0 added a commit to maplibre/flutter-maplibre-gl that referenced this pull request May 15, 2022
* Cherry-pick upstream#775 (Feature/771 ios onstyleready reliability)

https: //github.com/flutter-mapbox-gl/maps/pull/775

Co-Authored-By: Anton Averin <1481332+AAverin@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants