HOTFIX Add option to not use annotations - android performance #820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m0nac0
reviewed
Dec 16, 2021
m0nac0
reviewed
Dec 16, 2021
|
@m0nac0 rotating works fine for my device - even with texture mode turned off |
|
@m0nac0 one thing i noticed is that gestures don't work as expected after a screen rotation - however this is the case regardless of the textureMode |
tobrun
approved these changes
Dec 18, 2021
android/src/main/java/com/mapbox/mapboxgl/MapboxMapController.java
Outdated
Show resolved
Hide resolved
|
@tobrun a new release would be great as there have been lots of bug fixed pushed to master since the last release. However i would like to wait until after https://github.com/mapbox/mapbox-gl-js releases 2.6.2 as this fixes some major web issues |
m0nac0
added a commit
to maplibre/flutter-maplibre-gl
that referenced
this pull request
May 20, 2022
…android performance) https: //github.com/flutter-mapbox-gl/maps/pull/820 Co-Authored-By: Felix Horvat <24698503+felix-ht@users.noreply.github.com>
m0nac0
added a commit
to maplibre/flutter-maplibre-gl
that referenced
this pull request
May 20, 2022
…android performance) (#93) Cherry-pick upstream#820 (HOTFIX Add option to not use annotations - android performance) flutter-mapbox-gl/maps#820 Co-Authored-By: Felix Horvat <24698503+felix-ht@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android performance has been much worse than ios - even on good hardware. #632 #733 #525
The root cause for this are the annotation managers. It is listening to all map gestures - checking for drag events - causing a massive slow down even if no annotations are added. Why this causes such a massive slowdown is unknown.
This PR gives the option to pass an empty annotation order
annotationOrder: const []. If this is done the performance on android should be perfect. However if one does so, using the annotations is no longer possible.But with the support of geojson layers, on can still have custom dynamic maps, as long as drag is not needed.
I will fully fix this in the future by implementing the annotation managers in dart #779
I also disabled textureMode - this should give a big boost in performance in android in general as it moves the processing out of the ui thread.