Android embedding fixes - migrate to maven #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobrun
approved these changes
Jan 13, 2022
AAverin
reviewed
Feb 2, 2022
m0nac0
added a commit
to maplibre/flutter-maplibre-gl
that referenced
this pull request
May 13, 2022
flutter-mapbox-gl/maps#852 plus a temporary fix for the platform dependency (compile time error) Co-Authored-By: Felix Horvat <24698503+felix-ht@users.noreply.github.com>
m0nac0
added a commit
to maplibre/flutter-maplibre-gl
that referenced
this pull request
May 13, 2022
* 710 (Get rid of MapboxGlPlatform.getInstance) flutter-mapbox-gl/maps#710 * 852( Android embedding fixes - migrate to maven) flutter-mapbox-gl/maps#852 was also required to fix compile time errors * a small fix for the platform dependency * Update CI flutter version * cherry-pick upstream#904 (fix android build issues) Co-authored-by: shroff <502644+shroff@users.noreply.github.com> Co-authored-by: Felix Horvat <24698503+felix-ht@users.noreply.github.com>
mario-jerkovic
pushed a commit
to mario-jerkovic/flutter_mapbox_gl
that referenced
this pull request
Sep 24, 2022
* Migrate maven repository from jcenter to mavenCentral * Migrate maven repository from jcenter to mavenCentral * migrate to maven fix android embedding issue Co-authored-by: luis felipe de oliveira <loliveira@inspectos.com> (cherry picked from commit bd2ade0)
mario-jerkovic
pushed a commit
to mario-jerkovic/flutter_mapbox_gl
that referenced
this pull request
Sep 24, 2022
* Migrate maven repository from jcenter to mavenCentral * Migrate maven repository from jcenter to mavenCentral * migrate to maven fix android embedding issue Co-authored-by: luis felipe de oliveira <loliveira@inspectos.com> (cherry picked from commit bd2ade0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #817 - moved to a local branch to enable full ci builds. Thanks @lfofelipe for doing the maven changes.
Also did some changes to the android embedding that have been missed - this caused some build failures.