Support flutter3 #721
Merged
Support flutter3 #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for now let's throw an assertion error because I think we should crash in this case
jonasbark
reviewed
May 12, 2022
| @@ -38,10 +38,10 @@ android { | |||
|
|
|||
| dependencies { | |||
| implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:$kotlin_version" | |||
| implementation "androidx.lifecycle:lifecycle-runtime-ktx:2.3.1" | |||
| implementation "androidx.lifecycle:lifecycle-runtime-ktx:2.4.1" | |||
There was a problem hiding this comment.
are these dependency updates on purpose? Otherwise, I'd follow the versions from stripe-react-native
There was a problem hiding this comment.
yeah I thought upgrading those minors couldn't hurt but no problem reverting this. However I would like to upgrade the gradle stuff since it gets rid of a lot of warnings and also the Flutter team recommends these versions now
This was referenced May 14, 2022
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #718
Let's wait with merging until we got clarity on the cardfield