-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass only a preferred language to the engine #166
Pass only a preferred language to the engine #166
Conversation
e9e4bf6
to
2be4a1a
Compare
The previous change (e9e4bf6) was still okay for usual cases, but I wanted the implementation to be robust enough to handle special cases like Please refer to https://flutter.dev/docs/development/accessibility-and-localization/internationalization for a simple reproduction case. |
I'm little confused.. the previous change (e9e4bf6) has only filename change. (What am I missing?) and |
@bwikbs Basically the both implementations (
|
@swift-kim Now I understand! Thanks! ❤️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Pass only a preferred language to the engine * Log the current language
* Pass only a preferred language to the engine * Log the current language
* Pass only a preferred language to the engine * Log the current language
* Pass only a preferred language to the engine * Log the current language
* Pass only a preferred language to the engine * Log the current language
* Pass only a preferred language to the engine * Log the current language
* Pass only a preferred language to the engine * Log the current language
* Pass only a preferred language to the engine * Log the current language
* Pass only a preferred language to the engine * Log the current language
Potentially fixes flutter-tizen/flutter-tizen#184. More testing is required.