Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dart analyze issues #384

Merged
merged 3 commits into from
May 18, 2022
Merged

Fix dart analyze issues #384

merged 3 commits into from
May 18, 2022

Conversation

HakkyuKim
Copy link
Contributor

@HakkyuKim HakkyuKim commented May 12, 2022 •
edited
Loading

Also add missing sqflite label to labeler.yaml

@HakkyuKim HakkyuKim changed the title Fix dart analyze [sqflite] Fix dart analyze May 12, 2022
@HakkyuKim HakkyuKim marked this pull request as draft May 12, 2022 02:13
@HakkyuKim HakkyuKim force-pushed the fix-dart-analyze branch 2 times, most recently from c17d795 to 3df5224 Compare May 12, 2022 03:23
@github-actions github-actions bot added needs-publishing The package should be published after merge p: webview_flutter labels May 12, 2022
@HakkyuKim HakkyuKim changed the title [sqflite] Fix dart analyze Fix dart analyze May 12, 2022
@HakkyuKim HakkyuKim removed the needs-publishing The package should be published after merge label May 12, 2022
@github-actions github-actions bot added the needs-publishing The package should be published after merge label May 12, 2022
@HakkyuKim HakkyuKim added p: sqflite and removed needs-publishing The package should be published after merge labels May 12, 2022
@HakkyuKim HakkyuKim marked this pull request as ready for review May 12, 2022 03:38
@swift-kim swift-kim changed the title Fix dart analyze Fix dart analyze issues May 12, 2022
@github-actions github-actions bot added the needs-publishing The package should be published after merge label May 12, 2022
@HakkyuKim HakkyuKim removed the needs-publishing The package should be published after merge label May 12, 2022
@swift-kim
Copy link
Member

Note: The tool PR for Flutter 3.0 update is now ready.

@github-actions github-actions bot added the needs-publishing The package should be published after merge label May 18, 2022
@HakkyuKim
Remove some ignore directives
8dda374 
- Sort entries in labeler alphabetically.
- Add missing tizen_notification label.
swift-kim
swift-kim approved these changes May 18, 2022
View reviewed changes
Copy link
Member

@swift-kim swift-kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally the CI works now!

@swift-kim swift-kim merged commit 22be924 into flutter-tizen:master May 18, 2022
@swift-kim swift-kim removed the needs-publishing The package should be published after merge label May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swift-kim swift-kim swift-kim approved these changes

Assignees
No one assigned
Labels
p: integration_test p: sqflite p: webview_flutter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HakkyuKim @swift-kim